Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4945

Wicket-atmosphere filters should be functions on AtmosphereResource

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 6.4.0
        • Fix Version/s: 6.6.0
        • Component/s: wicket-atmosphere
        • Labels:
          None

          Description

          With a function on AtmosphereResource, rather than a predicate, it is possible to filter on attributes in the AtmosphereRequest. This would allow you to create filters that differentiate on the receiver, without relying on the heavy-weight contextAwareFilter().

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            laeubi Christoph Läubrich added a comment -

            I'll vote for this! The predicate also creates a dependecy on google jsut for the sake of using one single interface. A Wicket specific one would be mor appropiate and handling over the AtmosphereResource also would help for corner cases.

            Show
            laeubi Christoph Läubrich added a comment - I'll vote for this! The predicate also creates a dependecy on google jsut for the sake of using one single interface. A Wicket specific one would be mor appropiate and handling over the AtmosphereResource also would help for corner cases.
            Hide
            Permalink
            papegaaij Emond Papegaaij added a comment -

            Functions was not going to work, because the payload and resource were needed, so I created a tuple containing both. You how have access to the the payload and the resource. BTW, wicket-atmosphere has always had a dependency on guava, not just for Predicate, but also for other classes.

            Show
            papegaaij Emond Papegaaij added a comment - Functions was not going to work, because the payload and resource were needed, so I created a tuple containing both. You how have access to the the payload and the resource. BTW, wicket-atmosphere has always had a dependency on guava, not just for Predicate, but also for other classes.

              People

              • Assignee:
                papegaaij Emond Papegaaij
                Reporter:
                papegaaij Emond Papegaaij
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development