[WICKET-4909] ModalWindow overwrites window.onbeforeunload

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.3.0
• Fix Version/s: 6.13.0, 7.0.0-M1
• Component/s: wicket-extensions
• Labels: ajax event javascript modal wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Jesse Bonzo
• Created: 05/Dec/12 01:12
• Updated: 17/Dec/13 16:24
• Resolved: 17/Dec/13 16:24

Description

If window.onbeforeunload is changed after a ModalWindow is opened the change is lost when the ModalWindow is closed. I expected calling ModalWindow#showUnloadConfirmation(false) would fix this, but the javascript for the modal window unconditionally overwrites window.onbeforeunload. I suggest checking settings.unloadConfirmation before overwriting window.onbeforeunload.