Wicket
  1. Wicket
  2. WICKET-4890

Bad validation messages after WICKET-2128

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.3.0
    • Fix Version/s: 6.4.0
    • Component/s: None
    • Labels:
      None

      Description

      In most languages (at least the ones that I speak), the error messages used by validators don't sound right anymore after WICKET-2128 was fixed. Replacing '$

      {input}' with '${label}' (what seems to have been done) doesn't yield useful error messages.

      I see the following options:
      a) Improve the messages the way Martin Grigorov suggested it in WICKET-2128, e.g.
      'IConverter=The value of '${label}' is not a valid ${type}.'
      (instead of just 'IConverter='${label}' is not a valid ${type}.')
      Interestingly, all the languages that use .xml properties (e.g. Application_bg.properties.xml) files seem to have been excluded (by accident?) from the changes done in WICKET-2128, as they still refer to ${input}

      .

      b) revert the changes from WICKET-2128 completely. I think the new messages only fit well in scenarios where there's only a single feedback panel per page, which is anyway not very userfriendly. In cases when you display the error messages in separate feedback components next to the corresponding FormComponents, it is anyway clear which field is the culprit, and users don't need to search for the field that has caused the error.

      1. Application_no.properties
        2 kB
        Oddgeir Bell
      2. Application_fr.properties
        3 kB
        Jonas

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        10d 18h 23m 1 Martin Grigorov 07/Dec/12 09:23
        Martin Grigorov made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Sven Meier [ svenmeier ]
        Fix Version/s 6.4.0 [ 12323450 ]
        Resolution Fixed [ 1 ]
        Hide
        Martin Grigorov added a comment -

        Closing the ticket.
        Changes in the other resource bundles will be made when a native speaker sends updates.

        Show
        Martin Grigorov added a comment - Closing the ticket. Changes in the other resource bundles will be made when a native speaker sends updates.
        Hide
        Sven Meier added a comment -

        Thanks !

        Show
        Sven Meier added a comment - Thanks !
        Oddgeir Bell made changes -
        Attachment Application_no.properties [ 12555940 ]
        Hide
        Oddgeir Bell added a comment -

        New version of Norwegian properties

        Show
        Oddgeir Bell added a comment - New version of Norwegian properties
        Oddgeir Bell made changes -
        Comment [ New version of Norwegian properties ]
        Jonas made changes -
        Attachment Application_fr.properties [ 12555501 ]
        Hide
        Jonas added a comment -

        Proposed new version of Application_fr.properties
        (also eliminated duplicate keys)

        Show
        Jonas added a comment - Proposed new version of Application_fr.properties (also eliminated duplicate keys)
        Hide
        Jonas added a comment -

        I started preparing a patch for english and german when I realized that Sven has already taken care of this.
        Big thanks to Sven!
        Just one minor correction in Application_de_CH.properties: The following line has to be added, as 'grösser'
        is spelled differently in CH than in DE.
        RangeValidator.maximum=Der Wert von '$

        {label}

        ' ist gr\u00f6sser als der erlaubte Maximalwert $

        {maximum}

        .

        Show
        Jonas added a comment - I started preparing a patch for english and german when I realized that Sven has already taken care of this. Big thanks to Sven! Just one minor correction in Application_de_CH.properties: The following line has to be added, as 'grösser' is spelled differently in CH than in DE. RangeValidator.maximum=Der Wert von '$ {label} ' ist gr\u00f6sser als der erlaubte Maximalwert $ {maximum} .
        Hide
        Martin Grigorov added a comment -

        I've improved the messages in the _bg resource bundle.
        Patches for the language you speak are welcome!

        Show
        Martin Grigorov added a comment - I've improved the messages in the _bg resource bundle. Patches for the language you speak are welcome!
        Hide
        Sven Meier added a comment -

        I've updated the *.properties.xml fies to use $

        {label}

        too, so we get at least some consistency across languages.

        Show
        Sven Meier added a comment - I've updated the *.properties.xml fies to use $ {label} too, so we get at least some consistency across languages.
        Jonas made changes -
        Field Original Value New Value
        Affects Version/s 6.3.0 [ 12323327 ]
        Jonas created issue -

          People

          • Assignee:
            Sven Meier
            Reporter:
            Jonas
          • Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development