1. Wicket
  2. WICKET-4890

Bad validation messages after WICKET-2128


    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.3.0
    • Fix Version/s: 6.4.0
    • Component/s: None
    • Labels:


      In most languages (at least the ones that I speak), the error messages used by validators don't sound right anymore after WICKET-2128 was fixed. Replacing '$

      {input}' with '${label}' (what seems to have been done) doesn't yield useful error messages.

      I see the following options:
      a) Improve the messages the way Martin Grigorov suggested it in WICKET-2128, e.g.
      'IConverter=The value of '${label}' is not a valid ${type}.'
      (instead of just 'IConverter='${label}' is not a valid ${type}.')
      Interestingly, all the languages that use .xml properties (e.g. Application_bg.properties.xml) files seem to have been excluded (by accident?) from the changes done in WICKET-2128, as they still refer to ${input}


      b) revert the changes from WICKET-2128 completely. I think the new messages only fit well in scenarios where there's only a single feedback panel per page, which is anyway not very userfriendly. In cases when you display the error messages in separate feedback components next to the corresponding FormComponents, it is anyway clear which field is the culprit, and users don't need to search for the field that has caused the error.

      1. Application_fr.properties
        3 kB
      2. Application_no.properties
        2 kB
        Oddgeir Bell


        Jonas created issue -
        Jonas made changes -
        Field Original Value New Value
        Affects Version/s 6.3.0 [ 12323327 ]
        Jonas made changes -
        Attachment Application_fr.properties [ 12555501 ]
        Oddgeir Bell made changes -
        Comment [ New version of Norwegian properties ]
        Oddgeir Bell made changes -
        Attachment Application_no.properties [ 12555940 ]
        Martin Grigorov made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Sven Meier [ svenmeier ]
        Fix Version/s 6.4.0 [ 12323450 ]
        Resolution Fixed [ 1 ]


          • Assignee:
            Sven Meier
          • Votes:
            1 Vote for this issue
            5 Start watching this issue


            • Created: