[WICKET-4867] Detach the object before calculating its size

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.2.0, 1.5.9
• Fix Version/s: 6.3.0, 1.5.10
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Martin Tzvetanov Grigorov
• Created: 15/Nov/12 07:58
• Updated: 21/May/16 12:09
• Resolved: 22/Nov/12 12:32

Description

The debug panel in wicket-devutils uses WicketObjects#sizeOf() to calculate
the size of the page and the session.

The "problem" that I see is that it calculates the size of the non-detached
object. I think what really matters is the size after detaching it, because
this is what is being saved in the http session and the disk, and I guess
this is what the developer needs to know actually.

Issue Links

• breaks: WICKET-4878 Rendering of feedback messages fails with DebugBar in page
• relates to: WICKET-6166 JavaSerializer using CheckingObjectOutputStream fails in conjunction with PageSizeDebugPanel
• links to: Link to the discussion in dev@