Wicket
  1. Wicket
  2. WICKET-4820

Race condition in ResourceSettings: getResourceWatcher() is not thread safe

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.8, 6.1.1
    • Fix Version/s: 6.2.0, 1.5.9
    • Component/s: wicket
    • Labels:
      None

      Description

      o.a.w.settings.def.ResourceSettings.getResourceWatcher() is not thread safe: when multiple requests are waiting to load markup for the first time (for example, start "ab" with -c 40 right after starting the wicket application) multiple ModificationWatcher threads are started which cause a memory leak when the WicketApplication is stopped.

      1. WICKET-4820.zip
        26 kB
        Wolfgang Kritzinger

        Activity

        Wolfgang Kritzinger created issue -
        Hide
        Wolfgang Kritzinger added a comment -

        Quickstart that contains the test TestModificationWatcherRaceCondition that can reproduce the problem

        Show
        Wolfgang Kritzinger added a comment - Quickstart that contains the test TestModificationWatcherRaceCondition that can reproduce the problem
        Wolfgang Kritzinger made changes -
        Field Original Value New Value
        Attachment WICKET-4820.zip [ 12549518 ]
        Hide
        Martin Grigorov added a comment -

        Thanks!

        Show
        Martin Grigorov added a comment - Thanks!
        Martin Grigorov made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Martin Grigorov [ mgrigorov ]
        Fix Version/s 6.2.0 [ 12323295 ]
        Fix Version/s 1.5.9 [ 12322962 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Wolfgang Kritzinger
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development