Wicket
  1. Wicket
  2. WICKET-4808

WebClientInfo.getRemoteAddr() handling "Forwarded-For" value tokens not being ip addresses

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2.0, 1.5.9
    • Component/s: wicket
    • Labels:
      None

      Description

      In some environments, it is possible and valid to have a Forwarded-For header in the request, not containing an ip address but a value like "unknown" or "hidden". (See also http://www.squid-cache.org/Doc/config/forwarded_for/ for example).

      For that, I added tests and extended parsing logic with an address validation capable of parsing IPv4 and IPv6 values.

      Cheers
      Ben

      1. imp-WICKET-4808.patch
        7 kB
        Benjamin Steinert

        Activity

        Benjamin Steinert created issue -
        Benjamin Steinert made changes -
        Field Original Value New Value
        Attachment imp-WICKET-4808.patch [ 12548216 ]
        Benjamin Steinert made changes -
        Summary WebClientInfo.getRemoteAddr() handling "Forwarded-For"value tokens not being ip addresses WebClientInfo.getRemoteAddr() handling "Forwarded-For" value tokens not being ip addresses
        Martin Grigorov made changes -
        Fix Version/s 6.2.0 [ 12323295 ]
        Fix Version/s 1.5.9 [ 12322962 ]
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Martin Grigorov [ mgrigorov ]

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Benjamin Steinert
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development