Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4808

WebClientInfo.getRemoteAddr() handling "Forwarded-For" value tokens not being ip addresses

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 6.2.0, 1.5.9
    • wicket
    • None

    Description

      In some environments, it is possible and valid to have a Forwarded-For header in the request, not containing an ip address but a value like "unknown" or "hidden". (See also http://www.squid-cache.org/Doc/config/forwarded_for/ for example).

      For that, I added tests and extended parsing logic with an address validation capable of parsing IPv4 and IPv6 values.

      Cheers
      Ben

      Attachments

        1. imp-WICKET-4808.patch
          7 kB
          Benjamin Steinert

        Activity

          People

            mgrigorov Martin Tzvetanov Grigorov
            bensteinert Benjamin Steinert
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: