Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4808

WebClientInfo.getRemoteAddr() handling "Forwarded-For" value tokens not being ip addresses

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2.0, 1.5.9
    • Component/s: wicket
    • Labels:
      None

      Description

      In some environments, it is possible and valid to have a Forwarded-For header in the request, not containing an ip address but a value like "unknown" or "hidden". (See also http://www.squid-cache.org/Doc/config/forwarded_for/ for example).

      For that, I added tests and extended parsing logic with an address validation capable of parsing IPv4 and IPv6 values.

      Cheers
      Ben

        Attachments

          Activity

            People

            • Assignee:
              mgrigorov Martin Grigorov
              Reporter:
              bensteinert Benjamin Steinert
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: