Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.5.8, 6.0.0
-
Fix Version/s: 6.1.0
-
Component/s: wicket-extensions
-
Labels:None
Description
The fix in WICKET-3916 is not effective: https://fisheye6.atlassian.com/changelog/wicket?cs=1148229
As one can see in Component.internalRenderComponent(), the method Component.onComponentTag(), where the markup id is written to the tag, is called before the behavior had a chance to call setOutputMarkupId(true). (The Behavior.onComponentTag() is called in Component.renderComponentTag() a few lines down. The behavior has to call setOutputMarkupId() earlier, like in onConfigure()
Issue Links
- is a clone of
-
WICKET-4784
DOM ids change of the input fields of FilterToolbar
-
- Resolved
-
Activity
This particular problem is solved; the id attribute is now rendered, however the FilterToolbar component still doesn't work right. It uses a RefreshingView so the markupIds of the input field change constantly after a submit, so on the next page, the JavaScript is not able to change the focus to the element again (because the HTML id attribute has changed).
I'll attach a quickstart and a proposed patch.
Basic DefaultDataTable with only one column
proposed patch against master
Reopening
which versions work and don't work? Rather unclear what the status is of this issue.
Removed fix for 6.0.1 as we'll probably never release 6.0.1
I'm sorry for the lack of clarity, this issue is present in 1.5.8 and 6.0.0 (and master for that matter - the supplied patch is against master)
Fixed for 6.1.0, as the patch doesn't apply to 1.5.8 and I want to release 6.1.0 now.
This should fix it, but I don't currently have an easy way to test it. Please verify and re-open this issue if it's not fixed.
Master: https://git-wip-us.apache.org/repos/asf?p=wicket.git;a=commit;h=c274a707c2929e853907d3bd9b64e1582c16faac
1.5.x: https://git-wip-us.apache.org/repos/asf?p=wicket.git;a=commit;h=ac7748671472ac7d4f3f82e8801b607d3f73e5c2