[WICKET-475] NPE in WebClientInfo when user-agent header is not sent

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.6, 1.3.0-beta1
• Fix Version/s: 1.2.6, 1.3.0-beta1
• Component/s: wicket
• Assignee: Unassigned
• Reporter: Martijn Dashorst
• Created: 16/Apr/07 12:05
• Updated: 20/Apr/07 07:09
• Resolved: 20/Apr/07 07:09

Description

When the user agent http header is not set, the webclientinfo will throw either a NPE or a WicketRuntimeException (depending on the constructor called). This is not handy as the header can be omitted by clients.

In a discussion on @dev Eelco said:

I guess I was wrong in expecting a user agent header would always be
avaible. So WebClientInfo should accept null, and then in init() do
nothing.

Another thing I'm wondering is whether this is a quirk, or whether you
can expect a client that doesn't send a user-agent header to never
send it. Cause if is a quirk, and does send it with a next request, we
might want to try to reconstruct the WebClientInfo object. That's a
bit more complicated to achieve but doable. We just need to decide if
that's the best way to go.