[WICKET-4730] Filter component does not clear filter fields

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.0.0-beta3
• Fix Version/s: 6.1.0
• Component/s: wicket-extensions
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Andreas Kuhtz
• Created: 24/Aug/12 11:25
• Updated: 24/Sep/12 08:53
• Resolved: 04/Sep/12 10:03

Description

The GoAndClearFilter.onClearSubmit() does not clear filter fields because the originalState member has the current values of the filter. I think it should create a new instance of the originalState class instead of clone the model.

To verify use the phonebook sample (https://github.com/wicketstuff/core/tree/master/jdk-1.6-parent/phonebook). The clear only works if "go" was not pressed after enter some values in the filter, but if you press go and then want to clear the filter it keeps the values.

Attached is a patch that makes the phonebook sample work.

It might also be useful if the originalState attribute were made protected or accessible via protected method to allow users to overwrite the onClearSubmit() method and access the originalState attribute.