[WICKET-4695] Javascript error when closing a ModalWindow with IE 8

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.5
• Fix Version/s: 1.5.8, 6.0.0
• Component/s: wicket-extensions
• Labels: ModalWindow ajax javascript
• Environment: Internet Explorer 8
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Juha Syrjälä
• Created: 03/Aug/12 12:13
• Updated: 06/Aug/12 10:07
• Resolved: 06/Aug/12 10:07

Description

Closing a ModalWindow in IE 8 may cause following javascript error to console:

'win.current' is null or not an object

This doesn't happen with Chrome or Firefox and software seems to work correctly: ModalWindow closes correctly etc. This doesn't happen with all ModalWindows in my application, but if it happens, it will happen every time. I don't know what triggers this behavior, but a work around is to add null checks to ModalWindow.java and modal.js, currently there are only check for undefined variables.

ModalWindow.java, getCloseJavacriptInternal(), line 416 in wicket-1.5.5 source

+ "if (typeof(win) != \"undefined\" && typeof(win.current) != \"undefined\" && win.current != null) {\n"

modal.js, Window.close, line 258

if (typeof(win) != "undefined" && typeof(win.current) != "undefined" && win.current != null) {