Wicket
  1. Wicket
  2. WICKET-4658

TabbedPanel CSS "last" is wrong if last step is not visible

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 6.0.0-beta3
    • Fix Version/s: 6.7.0
    • Component/s: wicket-extensions
    • Labels:
      None

      Description

      TabbedPanel renders a "last" CSS class for the last tab, this fails however if the last tab is not visible.

        Activity

        Hide
        Cedric Gatay added a comment -

        I made a github pull request to fix this bug : https://github.com/apache/wicket/pull/21. Don't hesitate to tell me if a patch is preferred.

        Show
        Cedric Gatay added a comment - I made a github pull request to fix this bug : https://github.com/apache/wicket/pull/21 . Don't hesitate to tell me if a patch is preferred.
        Hide
        Martin Grigorov added a comment -

        Please attach the patch to this tikcet.
        Thanks!

        Show
        Martin Grigorov added a comment - Please attach the patch to this tikcet. Thanks!
        Hide
        Cedric Gatay added a comment -

        Here is the patch corresponding to this bug.
        I will close the unnecessary Github pull request.

        Show
        Cedric Gatay added a comment - Here is the patch corresponding to this bug. I will close the unnecessary Github pull request.
        Hide
        Sven Meier added a comment -

        Thanks Cedric! I've applied the patch with minor changes.

        Show
        Sven Meier added a comment - Thanks Cedric! I've applied the patch with minor changes.
        Hide
        Sven Meier added a comment -

        last tab is now correctly marked via css

        Show
        Sven Meier added a comment - last tab is now correctly marked via css

          People

          • Assignee:
            Sven Meier
            Reporter:
            Sven Meier
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development