[WICKET-4636] Using setResponsePage() before page rendering should skip the rendering of the page

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.7
• Fix Version/s: 1.5.8, 6.0.0-beta3
• Component/s: wicket
• Labels: redirect requestcycle
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Bertrand Guay-Paquet
• Created: 03/Jul/12 13:31
• Updated: 10/Jul/12 07:52
• Resolved: 10/Jul/12 07:46

Description

This ticket follows from the email thread http://markmail.org/thread/uk5y4ddoopntmkgd

When setResponsePage() is used, the current page is still rendered. The response thus generated is then thrown away completely and a replacement request handler is used. I can think of 3 reasons why this should be avoided:
1-Performance; it's wasteful to render components to discard them right away

2-Needs complete components hierarchy; even if setResponsePage() is used in a page constructor (e.g. when redirecting depending on page parameters), since the page will be rendered, all of its components or some substitutes must be added to the page. Otherwise Wicket will throw a missing component exception in dev mode.

3-Feedback messages; if the needlessly rendered page contains a feedback panel, feedback messages registered in the session will be swallowed by the thrown away page rendering.