Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4472

Modal window accessibility - add role and aria attributes to outer div for assitive technologies

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      For more accessible modal windows:

      1) it is desirable that the outer DIV element has a 'dialog' role defined and an 'aria-labelledBy' attribute pointing to the modal title text. This will help assistive technologies in properly alerting people with disabilities (PwD) users about the modal windows that wicket displays.
      Until I get familiar/ready for OSS contributions, I leave you a code snippet for modal.js (around line 1170)

      old:
      <div class=\"wicket-modal\" id=\""idWindow"\" style=\"top: 10px; left: 10px; width: 100px;\">

      new:
      <div class=\"wicket-modal\" id=\""idWindow"\" role=\"dialog\" aria-labelledBy=\""idCaptionText"\" style=\"top: 10px; left: 10px; width: 100px;\">

      2) it is desirable that the close icon of modal windows (top right corner) have associated text. This will help assistive technologies in properly labeling the icon. Also, because background images are hidden when high-contrast mode is active (Alt+Shift+PrtSc) the close icon should not be a background but rather an img tag, with appropriate alt attribute. Following is a suggestion of the proposed change in modal.js (around line 1191) except for the image source which I believe requires some rework from your side:

      old:
      "<a class=\"w_close\" style=\"z-index:1\" href=\"#\"></a>"+

      new:
      "<a style=\"z-index:1\" href=\"#\" title=\"close dialog\"><img src=\"???\" alt=\"close dialog\" /></a>"+

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            lukuperman Lucas

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack

                  Issue deployment