[WICKET-4129] setting getApplicationSettings().setDefaultMaximumUploadSize() has no effect

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 1.5.1, 1.5.2
• Component/s: wicket
• Labels: DefaultMaximumUploadSize GAE appspot fileupload multipart wicket
• Environment: GAE 1.5.5, wicket 1.5-snapshot
• Assignee: Sven Meier
• Reporter: Hielke Hoeve
• Created: 13/Oct/11 20:33
• Updated: 14/Oct/11 11:58
• Resolved: 14/Oct/11 07:37

Description

I am creating an Google Appspot - Wicket application and want to allow users to upload a file. This file can be upto 15MB, since Google uses a limited JRE it is not possible to create Files.

When setting DefaultMaximumUploadSize to 15MB nothing changes, Appspot still throws a SecurityException. Wicket is not really using the DefaultMaximumUploadSize setting at all, it is passed along the multipart handling but not used. The DiskFileItemFactory is not receiving the DefaultMaximumUploadSize and sticks to a default value of 10240.

I am unable to make a patch file at the moment, can make one later if need be. Here is the required change:

MultipartServletWebRequestImpl.java:90 is currently:

this(request, filterPrefix, maxSize, upload, new DiskFileItemFactory(Application.get().getResourceSettings().getFileCleaner()));

and it should be:

this(request, filterPrefix, maxSize, upload, new DiskFileItemFactory(maxSize, null, Application.get().getResourceSettings().getFileCleaner()));