[WICKET-4122] Event listener not properly detached for multipart AJAX requests

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.2
• Component/s: wicket
• Labels: ajax htmlunit javascript multipart wicket-ajax.js
• Environment: HtmlUnit
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Andreas Kappler
• Created: 11/Oct/11 14:15
• Updated: 12/Oct/11 11:34
• Resolved: 12/Oct/11 11:34

Description

We are using HtmlUnit for functional testing of a wicket application. We have several issues with it but one of the more critical problems arises whenever a multipart form is submitted via AJAX. Internally wicket apparently uses an iframe to submit the request and listens for the "load" event of this iframe to detect the success of the request.

The problem is that HtmlUnit fires the "load" event twice. I am not sure if this is a HtmlUnit problem (I do suspect that it is), but when looking at the wicket code I am wondering about these lines of javascript code:

Here in wicket-ajax.js:1215 the event is attached

Wicket.Event.add(iframe, "load", this.handleMultipartComplete.bind(this));

And later in wicket-ajax.js:1246 it is detached

// remove the event
if (iframe.detachEvent)
iframe.detachEvent("onload", this.handleMultipartComplete);
else
iframe.removeEventListener("load", this.handleMultipartComplete, false);

But because the bind function returns a new object this should never work, right? I have attached a patch that fixes the problem in my environment, please take a look at it if this makes sense.