Wicket
  1. Wicket
  2. WICKET-4115

SignInPanel should not always redirect to the Home page when the user is signed-in automaticaly with the remember-me feature.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.1
    • Fix Version/s: 6.7.0
    • Component/s: None
    • Labels:
      None

      Description

      If a SignInPanel is included in the header of non access protected pages, and the users goes directly to a page that is not the home page, the SignInPanel will sign him in with the remember-me feature (which is right), but then will redirect him to the home page (which is not right if the page is not access protected).

      See SignInPanel, line 133 & 136.

      => Add an overrideable method like :

      protected boolean shouldRedirectToHomePage()

      { return getPage().getClass().isInstance( ((AuthenticatedWebApplication)getApplication()).getSignInPageClass() ); }

      Note : Right now, AuthenticatedWebApplication.getSignInPageClass is protected. It has to be changed to public.

      That way, if the current page is the sign-in page, the redirect should indeed got to the home page if there is no intercept page.
      Otherwise, the requested page has probably no restricted access as it has not been redirected to the SignIn page. So after the automatic sign-in we should just carry on and display the current (and requested) page.

        Activity

        Hide
        Sylvain Vieujot added a comment -

        Once the shouldRedirectToHomePage method has been added, the current SignInPanel, line 133 should read :

        if( !continueToOriginalDestination() && shouldRedirectToHomePage() )

        Show
        Sylvain Vieujot added a comment - Once the shouldRedirectToHomePage method has been added, the current SignInPanel, line 133 should read : if( !continueToOriginalDestination() && shouldRedirectToHomePage() )
        Hide
        Sven Meier added a comment -

        overrideable #onSignInRemembered() allows you to stay on the page now

        Show
        Sven Meier added a comment - overrideable #onSignInRemembered() allows you to stay on the page now

          People

          • Assignee:
            Sven Meier
            Reporter:
            Sylvain Vieujot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development