[WICKET-4096] AjaxIndicatorAppender.renderHead does not pass Components id in its call of renderJavaScript

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.2
• Component/s: wicket-extensions
• Labels: javascript wicket
• Environment: Windows 32bit XP, Tomcat 7, java6 and scala 2.9.1, build with Eclipse
• Assignee: Igor Vaynberg
• Reporter: Marcus Bosten
• Created: 29/Sep/11 15:28
• Updated: 29/Sep/11 18:18
• Resolved: 29/Sep/11 17:08

Description

In an AjaxEditalbeLabel we set an int - that will reload a dataview with number of lines as given in the AjaxEditingLabel.
In that dataview we use IndicatingAjaxLink to sort the columns. With Wicket 1.4.18 that worked well.

With Wicket 1.5.0 in this scenario, if the AjaxEditalbeLabels onSubmit(...) Method is called, an error occurred:
Root cause:

java.lang.IllegalArgumentException: Argument 'id' may not be null.
at org.apache.wicket.util.lang.Args.notNull(Args.java:39)
at org.odlabs.wiquery.core.AbstractWiQueryDecoratingHeaderResponse.renderJavaScript(AbstractWiQueryDecoratingHeaderResponse.java:128)
at org.apache.wicket.extensions.ajax.markup.html.AjaxIndicatorAppender.renderHead(AjaxIndicatorAppender.java:71)
at org.apache.wicket.Component.renderHead(Component.java:2662)
at org.apache.wicket.ajax.AjaxRequestTarget$3.component(AjaxRequestTarget.java:1256)
...

We found that the AjaxIndicatorAppender.renderHead calls the org.odlabs.wiquery.core.AbstractWiQueryDecoratingHeaderResponse.renderJavaScript(someJavaScript, null)
The method renderJavaScript expicitly checks if the second parameter is null and throws an Error here.

Imho the AjaxIndicatorAppender.renderHead should pass the components id instead of the null.

By the way: Wicket rocks anyway, but 1.5 is another Highlight!
Thanks a lot and best Regards,
Marcus Bosten