Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4080

domready events not always fired in IE

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.18, 1.5.0
    • Fix Version/s: 1.4.19, 1.5.1
    • Component/s: wicket
    • Labels:
      None

      Description

      The domready events for IE rely on a onreadystatechange to state 'complete'. Normally, this state should go from 'loading', to 'complete' to 'loaded'. However, IE does not always trigger events for all states. Why it skips certain events, I don't know, but it seems related to other content being loaded at the same time. Perhaps IE does not find the time to trigger the event and simply skips a step. If it skips 'loading' or 'loaded', there is no problem, but if it skips 'complete', the domready scripts will never run. I've never seen it skip more than one state, therefore I propose the attached patch, which also checks for 'loaded'.

      Although nothing has changed for a long time in wrt domready, this now is a serious issue when using the latest version of wiquery. The reason is that wiquery changes the order in which javascript files are added to head, and this different order causes IE to skip states far more frequently.

      1. dom-ready-ie-fix.patch
        0.8 kB
        Emond Papegaaij

        Issue Links

          Activity

          Hide
          dashorst Martijn Dashorst added a comment -

          If 1.5.1 is rerolled and taken from trunk again, we need to modify the fix version.

          Show
          dashorst Martijn Dashorst added a comment - If 1.5.1 is rerolled and taken from trunk again, we need to modify the fix version.

            People

            • Assignee:
              dashorst Martijn Dashorst
              Reporter:
              papegaaij Emond Papegaaij
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development