Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4027

Consider dropping MockPageManager and use mock IPageStore instead

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Later
    • 1.5-RC7
    • None
    • wicket
    • None

    Description

      Currently WicketTester setups custom IPageManager (MockPageManager) which has several problems:
      1) it saves stateless pages - touchPage(statelessPage) shouldn't be stored
      2) it calls #detach() for all pages ever stored in the map. it should call it only on the pages stored in the last request.

      If we fix these problems then we are going to reimplement the default IPageManager (StorePageManager). So I suggest to drop MockPageManager and setup inmemory IPageStore behind it instead. This way we can test PageStoreBehavior as well.

      Attachments

        1. WICKET-4027-2.patch
          2 kB
          Martin Tzvetanov Grigorov

        Issue Links

          Activity

            People

              Unassigned Unassigned
              mgrigorov Martin Tzvetanov Grigorov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: