[WICKET-3994] MockWebApplication double invocation of cycle.detach()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.16, 1.4.17, 1.4.18
• Fix Version/s: 1.4.19
• Component/s: wicket
• Assignee: Igor Vaynberg
• Reporter: Daniele Cremonini
• Created: 25/Aug/11 08:31
• Updated: 17/Sep/11 17:56
• Resolved: 17/Sep/11 17:56

Description

Porting JAMon integration to Wicket 1.4 test JamonMonitoredWebRequestCycleTest (a WicketStuff class) fails do I discovered a double invocation that seems a bug. Explanation follows.

MockWebApplication.processRequestCycle(WebRequestCycle) method calls

cycle.request();

then

cycle.detach();

but cycle.detach() is also called inside cycle.request() resulting in a double invocation.

public void processRequestCycle(WebRequestCycle cycle)
{
try
{
cycle.request();
if (cycle.wasHandled() == false)

{ cycle.setRequestTarget(new WebErrorCodeResponseTarget( HttpServletResponse.SC_NOT_FOUND)); }

cycle.detach(); // <== second invocation, I would remove it
createRequestCycle();
parametersForNextRequest.clear();
servletRequest.getParameterMap().clear();
}
finally

{ cycle.getResponse().close(); }

postProcessRequestCycle(cycle);
}