Wicket
  1. Wicket
  2. WICKET-399

Make RestartResponseAtInterceptPageException with a SignIn-type page work correctly from AjaxFallbackLink

    Details

    • Type: Wish Wish
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.2.5
    • Fix Version/s: 1.3.5
    • Component/s: wicket
    • Labels:
      None

      Description

      If you throw a new RestartResponseAtInterceptPageException from inside onClick in an AjaxFallbackLink, Wicket does the right thing in redirecting you to a SignIn page, but upon completing the sign-in, the continueToOriginalDestination() call continues to the Ajax response (which isn't particularly surprising).

      It might be nice to have magic added to make this work seamlessly and restart the onClick() somehow. It would be adequate to make the AjaxFallBackLink behave as though fallback had happened in this situation.

      A fairly simple workaround is to check in the Panel/Page to see if sign-in has happened already and use a normal Link in the case that it hasn't.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        559d 10h 29m 1 Igor Vaynberg 27/Sep/08 07:52
        Igor Vaynberg made changes -
        Resolution Won't Fix [ 2 ]
        Assignee Igor Vaynberg [ ivaynberg ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Igor Vaynberg added a comment -

        the restartresponseatinterceptpage works exactly as it should. we might be able to improve this somewhat in the upcoming 1.5.

        Show
        Igor Vaynberg added a comment - the restartresponseatinterceptpage works exactly as it should. we might be able to improve this somewhat in the upcoming 1.5.
        Martijn Dashorst made changes -
        Fix Version/s 1.3.4 [ 12313089 ]
        Fix Version/s 1.3.5 [ 12313175 ]
        Frank Bille Jensen made changes -
        Fix Version/s 1.3.4 [ 12313089 ]
        Fix Version/s 1.3.3 [ 12313047 ]
        Frank Bille Jensen made changes -
        Fix Version/s 1.3.3 [ 12313047 ]
        Fix Version/s 1.3.2 [ 12312942 ]
        Frank Bille Jensen made changes -
        Fix Version/s 1.3.2 [ 12312942 ]
        Fix Version/s 1.3.1 [ 12312500 ]
        Jean-Baptiste Quenot made changes -
        Assignee Jean-Baptiste Quenot [ jbq ]
        Frank Bille Jensen made changes -
        Fix Version/s 1.3.1 [ 12312500 ]
        Fix Version/s 1.3.0-rc3 [ 12312886 ]
        Frank Bille Jensen made changes -
        Fix Version/s 1.3.0-rc3 [ 12312886 ]
        Fix Version/s 1.3.0-rc2 [ 12312513 ]
        Frank Bille Jensen made changes -
        Fix Version/s 1.3.0-rc2 [ 12312513 ]
        Fix Version/s 1.3.0-rc1 [ 12312818 ]
        Eelco Hillenius made changes -
        Fix Version/s 1.3.0-beta5 [ 12312818 ]
        Hide
        Eelco Hillenius added a comment -

        Assigned version (beta 4)

        Show
        Eelco Hillenius added a comment - Assigned version (beta 4)
        Hide
        Jean-Baptiste Quenot added a comment -

        Hi Nick, any chance you can play with this new class and tell us if it fits your needs?

        Show
        Jean-Baptiste Quenot added a comment - Hi Nick, any chance you can play with this new class and tell us if it fits your needs?
        Jean-Baptiste Quenot made changes -
        Hide
        Jean-Baptiste Quenot added a comment -

        You don't necessarily need Wicket sources to test that class. Just put it in your project while respecting the package naming. I will attach the class here to make it easier for you to test.

        Show
        Jean-Baptiste Quenot added a comment - You don't necessarily need Wicket sources to test that class. Just put it in your project while respecting the package naming. I will attach the class here to make it easier for you to test.
        Hide
        Nick Johnson added a comment -

        Sorry, I haven't had a chance to test it yet. I have to admit that I don't have the Wicket sources on my machine at the moment, so I'll need to do that and rebuild first.

        This weekend's gonna be pretty busy, but I'll see if I can get to it.

        Show
        Nick Johnson added a comment - Sorry, I haven't had a chance to test it yet. I have to admit that I don't have the Wicket sources on my machine at the moment, so I'll need to do that and rebuild first. This weekend's gonna be pretty busy, but I'll see if I can get to it.
        Hide
        Jean-Baptiste Quenot added a comment -

        Hi Nick, have you been able to test the new RestartResponseAtOriginalDestination class? I need your confirmation for adding this class to Wicket.

        Show
        Jean-Baptiste Quenot added a comment - Hi Nick, have you been able to test the new RestartResponseAtOriginalDestination class? I need your confirmation for adding this class to Wicket.
        Jean-Baptiste Quenot made changes -
        Hide
        Jean-Baptiste Quenot added a comment -

        Same with a ".txt" extension

        Show
        Jean-Baptiste Quenot added a comment - Same with a ".txt" extension
        Jean-Baptiste Quenot made changes -
        Hide
        Jean-Baptiste Quenot added a comment -

        Please see attached a new exception class called RestartResponseAtOriginalDestination that I worked out a long time ago. Please apply it to Wicket sources with the "patch" command. If it works for you, I can add it to Wicket.

        Show
        Jean-Baptiste Quenot added a comment - Please see attached a new exception class called RestartResponseAtOriginalDestination that I worked out a long time ago. Please apply it to Wicket sources with the "patch" command. If it works for you, I can add it to Wicket.
        Jean-Baptiste Quenot made changes -
        Field Original Value New Value
        Assignee Jean-Baptiste Quenot [ jbq ]
        Nick Johnson created issue -

          People

          • Assignee:
            Igor Vaynberg
            Reporter:
            Nick Johnson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development