Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-3935

DynamicImageResource shouldn't be that lazy

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.5-RC5.1
    • 1.5-RC6
    • wicket
    • None

    Description

      Currently DynamicImageResource asks for the image data in WriteCallback#write(Attributes). This is a bit too late because there is no way to say "there is no image".
      I'm suggesting to move the call to getImageData() a bit earlier so if it returns null then 404 is returned.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mgrigorov Martin Tzvetanov Grigorov
            mgrigorov Martin Tzvetanov Grigorov
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment