Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-3884 Null model for AttributeAppender should not render empty attribute
  3. WICKET-3934

Provide AttributeModifier#remove(String)

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.5.1
    • wicket
    • None

    Description

      Please provide AttributeModifier#remove(String) method which deals with the internals in AttributeModifier.

      AttributeModifier has special constants : VALUELESS_ATTRIBUTE_ADD and VALUELESS_ATTRIBUTE_REMOVE which are checked with String#equals(). This disallows to set an attribute with their value. It will be better if they are created with 'new String(...)' and later checked by identity. They are static so there is no chance to be interned during deserialization.

      Attachments

        1. WICKET-3934.patch
          3 kB
          Attila Király

        Issue Links

          is broken by

          Bug - A problem which impairs or prevents the functions of the product. WICKET-6279 AttributeModifier.VALUELESS_ATTRIBUTE_REMOVE does not work after deserialisation

          • Major - Major loss of function.
          • Closed

          Activity

            People

              mgrigorov Martin Tzvetanov Grigorov
              mgrigorov Martin Tzvetanov Grigorov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: