[WICKET-3903] Split AutoLabelResolver into wicket:for and wicket:label

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.18, 1.5-RC6
• Fix Version/s: 1.4.18, 1.5-RC6
• Component/s: wicket
• Assignee: Igor Vaynberg
• Reporter: Carl-Eric Menzel
• Created: 14/Jul/11 18:49
• Updated: 15/Aug/11 14:28
• Resolved: 21/Jul/11 05:52

Description

AutoLabelResolver is combining two different things - managing the "for" attribute in <label>, and managing FormComponent#getLabel.

After an IRC conversation with martin-g and ivaynberg, I propose splitting this behavior into two parts, as done in the upcoming patch. Use wicket:for as before, use <wicket:label> to output or pick up the label string. See AutoFormComponentLabelResolver for details.

AutoLabelResolver also did not play nice with Enclosure - it would confuse Enclosure and make it throw ArrayIndexOutOfBoundExceptions. That could be cured by having AutoLabelTagResolver do setAutoComponentTag=true, but that again would break AutoLabelResolver's <span> magic. By splitting it up like this, that issue is avoided, and wicket:for, wicket:label and Enclosure play nicely together.

Issue Links

• incorporates: WICKET-3894 AutoLabelResolver breaks when the label contains wicket:message or a nested component