Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-388

Change log statement in Objects#setObjectStreamFactory()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 1.3.0-beta1
    • 1.3.0-beta2
    • wicket
    • None

    Description

      Currently, setObjectStreamFactory looks like this:

      public static void setObjectStreamFactory(IObjectStreamFactory objectStreamFactory)
      {
      if (objectStreamFactory == null)

      { Objects.objectStreamFactory = new IObjectStreamFactory.DefaultObjectStreamFactory(); }

      else

      { Objects.objectStreamFactory = objectStreamFactory; }

      log.info("using " + objectStreamFactory + " for creating object streams");
      }

      In my Application.init(), I tell Wicket to use the WicketObjectStreamFactory with this line:
      Objects.setObjectStreamFactory(new wicket.util.io.WicketObjectStreamFactory()); // custom serialization

      or the default ObjectStreamFactory with this line:
      Objects.setObjectStreamFactory(null); // jdk serialization

      However, in my log, when I use the default (null) it outputs:
      10:40:42,921 INFO Objects:1156 - using null for creating object streams

      instead of showing REAL object that it is using.

      I recommend changing this line
      log.info("using " + objectStreamFactory + " for creating object streams");

      to this
      log.info("using " + Objects.objectStreamFactory + " for creating object streams");

      Attachments

        Activity

          People

            jbq Jean-Baptiste Quenot
            cdeal Chuck Deal
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: