Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-3784

ListMultipleChoice should allow its model to return a different collection on each access

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.17
    • Fix Version/s: 1.5-RC6
    • Component/s: wicket
    • Labels:

      Description

      With revision 646020 an unnecessary restriction was introduced to ListMultipleChoice, as the model is no longer allowed to return different collections on each invocation of #getObject().

      Note that this change is in conflict with the javadoc of #updateModel() which explicitely allows such usage:
      /**

      • If the model object exists, it is assumed to be a Collection, and it is modified in-place.
      • Then {@link Model#setObject(Object)}

        is called with the same instance: it allows the Model to

      • be notified of changes even when {@link Model#getObject()}

        returns a different

      • {@link Collection}

        at every invocation.
        */

      Please remove the check for identity of the model object, see attached patch.

      Thanks

        Attachments

          Activity

            People

            • Assignee:
              svenmeier Sven Meier
              Reporter:
              svenmeier Sven Meier

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment