Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-3766

Strings#escapeMarkup() creates invalid XML for control characters

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.17
    • 1.4.18
    • wicket

    Description

      Most C0 control characters are invalid in XML:

      http://en.wikipedia.org/wiki/Valid_characters_in_XML

      Besides 0x09, 0x0a and 0x0d all other control characters below 0x20 have to be escaped, see attached patch.

      Currently model objects containing these characters and being rendered (e.g. via labels) will lead to Ajax response failures.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mgrigorov Martin Tzvetanov Grigorov
            svenmeier Sven Meier
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment