[WICKET-3759] Touch the page only when it is just read from the page store

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5-RC4
• Fix Version/s: 1.5-RC5
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Martin Tzvetanov Grigorov
• Created: 01/Jun/11 20:47
• Updated: 27/Jun/11 15:03
• Resolved: 03/Jun/11 10:05

Description

Currently PageProvider#getPageInstance() "touches" the page for each call, i.e. schedules it to be persisted at the end of the request life. This always goes to PageAccessSynchronizer#touchPage() and respectively #lockPage().
With the suggested patch this will be done at most once per PageProvider#getPage().
This change causes some tests related to error pages to fail. The problem is that ALWAYS_REDIRECT is used for error pages thus REDIRECT_TO_RENDER strategy which expects the page to be stored before the redirect. Changing it to AUTO_REDIRECT leads to the default REDIRECT_TO_BUFFER to be used and the problem is solved because the response is buffered in the special map and the page is not needed after the redirect.

Issue Links

• breaks: WICKET-3836 regression on strategy to integrate cas authentication