Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-3675

Usage of JavaScriptCompressor by resources other than PackageTextTemplates is lost!

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.5-M1, 1.5-M2.1, 1.5-M3, 1.5-RC1, 1.5-RC2, 1.5-RC3, 1.5-RC4
    • 1.5-RC5
    • wicket

    Description

      With the refactoring of ResourceReferences, Resources and ResourceStreams it seems that the JavaScriptCompressor is no longer used for resources other than a PackageTextTemplate. In Wicket 1.4 it used to be in JavascriptPackageResource but seeing as this class is gone the JavaScriptCompressor is no longer used.

      There should be either a subclass of PackageResource which uses the JavaScriptCompressor or a way to intercept the length and the bytes which are written to the stream in PackageResource line 327.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mgrigorov Martin Tzvetanov Grigorov
            hielkehoeve Hielke Hoeve
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment