[WICKET-3513] AbstractDefaultAjaxBehavior generates broken Javascript

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 1.4.16, 1.5-RC2
• Component/s: wicket
• Labels: javascript
• Environment: n/a
• Assignee: Igor Vaynberg
• Reporter: Stijn de Witt
• Created: 07/Mar/11 09:43
• Updated: 10/Mar/11 16:42
• Resolved: 09/Mar/11 07:57

Description

org.apache.wicket.ajax.AbstractDefaultAjaxBehavior#generateCallbackScript is generating Javascript code of the form:

if (condition)

{Wicket.hideIncrementally()} var wcall = <ajax call code>; Wicket.showIncrementally();

It should either be:

if (condition) {Wicket.hideIncrementally(); var wcall = <ajax call code>; Wicket.showIncrementally(); }

(notice the moved closing brace of the if-block)

or:

if (condition) {Wicket.hideIncrementally()}

var wcall = <ajax call code>; if (condition)

{Wicket.showIncrementally()}

Any way, the calls to Wicket.hideIncrementally and Wicket.showIncrementally should be balanced. Now they are not, which may trigger, in some circumstances (when 'condition' == true) a call to showIncrementally when there was never a call to hideIncrementally, disturbing the balance in such a way that the busy indicator keeps spinning forever.

Also see my related posts on the Wicket User List:

Possible bug in org.apache.wicket.ajax.AbstractDefaultAjaxBehavior
http://apache-wicket.1842946.n4.nabble.com/Possible-bug-in-org-apache-wicket-ajax-AbstractDefaultAjaxBehavior-td3335256.html

With kind regards,

-Stijn