[WICKET-3423] org.apache.wicket.request.handler.resource.ResourceStreamRequestHandler equals not Symmetric

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.5-RC1
• Fix Version/s: 1.5-RC2
• Component/s: wicket
• Environment: all
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Richard Emberson
• Created: 04/Feb/11 17:20
• Updated: 11/Feb/11 17:10
• Resolved: 11/Feb/11 17:10

Description

If A is a ResourceStreamRequestHandler with a null fileName while
B is a ResourceStreamRequestHandler with a non-null fileName but both have the same
resourceStream, then

A.equals(B) == true
B.equals(A) == false

Is that what is wanted?

public boolean equals(Object obj)
{
if (obj instanceof ResourceStreamRequestHandler)

{ ResourceStreamRequestHandler that = (ResourceStreamRequestHandler)obj; return resourceStream.equals(that.resourceStream) && ((fileName == null) || fileName.equals(that.fileName)); }

return false;
}