Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-341

[Patch] AjaxServerAndClientTimeFilter either throws an exception or displays a wrong text

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0 branch (discontinued)
    • 1.3.0-beta2
    • wicket
    • None

    Description

      When IResourceSettings.getThrowExceptionOnMissingResource() is true (the default value), the AjaxServerAndClientTimeFilter throws MissingResourceException instead of displaying a default message "Server parsetime: X, Client parsetime: Y".

      Moreover, when "ServerAndClientTimeFilter.statustext" and "ajax.ServerAndClientTimeFilter.statustext" resource keys are defined, it does not throw the exception, but a wrong message is displayed — ${servertime} and ${clienttime} variables in the resource string are not interpolated.

      The attached patch fixes both bugs.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            almaw Alastair Maw
            bendis Martin Benda
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment