Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-336

Inheritable model cannot be a wrap model

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.3.0-rc1
    • 1.3.0-rc1
    • wicket
    • None
    • n.a.

    Description

      In the code of Component:initModel(), when it comes accross an IWrapModel, it always gets its nested model, not considering if this model itself might be an IInheritableModel.

      for (Component current = getParent(); current != null; current = current.getParent())
      {
      // Get model
      IModel model = current.getModel();

      if (model instanceof IWrapModel)

      { model = ((IWrapModel)model).getNestedModel(); }

      if (model instanceof IInheritableModel)
      { .... }
      }

      Would it be correct do make the following correction ?

      if (model instanceof IWrapModel && !(model instanceof IInheritableModel))
      { model = ((IWrapModel)model).getNestedModel(); }

      Attachments

        Activity

          People

            jcompagner Johan Compagner
            jan.vermeulen@isencia.com Jan Vermeulen
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: