[WICKET-3315] PackagedTextTemplate should set lastModifiedTime

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.15
• Fix Version/s: 1.4.16, 1.5-RC1
• Component/s: wicket
• Assignee: Peter Ertl
• Reporter: Guillaume Smet
• Created: 09/Jan/11 10:31
• Updated: 12/Jan/11 00:26
• Resolved: 11/Jan/11 13:50

Description

Hi,

When using TextTemplateResourceReference in a setAddLastModifiedTimeToResourceReferenceUrl(true) configuration, the w:lm parameter isn't added to the URL of the resource as PackagedTextTemplate.lastModifiedTime() (called in TextTemplateResourceReference.lastModifiedTime()) always returns null.

IMHO, PackagedTextTemplate should set lastModifiedTime when accessing the resource.

AFAICS, the cache code at the top of PackagedTextTemplate isn't used at all so I think we can simply set it in the constructor when we access the stream. This is what the attached patch does.

Any comment?

–
Guillaume