[WICKET-3288] Remove "id" from Toolbar constructors

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5-RC1
• Assignee: Juegen Donnerstag
• Reporter: Juegen Donnerstag
• Created: 28/Dec/10 11:49
• Updated: 06/Aug/13 09:58
• Resolved: 28/Dec/10 11:59

Description

ooks like you did it in r894726 to fix wicket-2620?

-igor

• Hide quoted text -

On Tue, Dec 21, 2010 at 10:23 PM, Juergen Donnerstag
<[e-mail]> wrote:
> I'm not aware I did it. Did I make that change when I made the
> MarkupFragment changes? Since I don't recall I did for a good reason
> feel free to change it.
>
> -Juergen
>
>>On Tue, Dec 21, 2010 at 9:16 PM, Igor Vaynberg <[e-mail]> wrote:
>> hey, i noticed you made it so that we need to pass ids to toolbars.
>> this seems a little weird to me, especially since ids are never
>> referenced in the markup by the user.
>>
>> the javadoc also doesnt say anything about them, from the looks of
>> things it just needs to be a unique string? can we not change it to
>> how it was and generate the unique strings ourselves, perhaps
>> toolbar.getsimpleclassname()+some counter to make it unique based on
>> other toolbars already added?
>>
>> just seems weird to me.
>>
>> cheers,
>> -igor
>>
>

Issue Links

• is related to: WICKET-5303 Static id counter AbstractToolbar prevents stable component paths for testing