Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-3128

FormComponentLabel should open open-close tags like Label does

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.4.12, 1.5-M2.1
    • 1.4.13, 1.5-M3
    • wicket
    • None

    Description

      Seems to affect all versions.

      FormComponentLabel nor it's subclass SimpleFormComponentLabel open the tag like Label does.

      While writing <label wicket:id="xyz"/> is invalid XHTML I'd argue this should be supported as Label will expand tags as well.

      FormComponentLabel asserts that the tags name is "label", so that's the reasoning behind implementing it there (in the patch attached).

      Patch is trivial and identical for both 1.4 and 1.5 branches.

      Attachments

        1. wicket-3128.patch
          0.6 kB
          Joonas Koivunen

        Activity

          People

            jthomerson Jeremy Thomerson
            koivunej Joonas Koivunen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: