[WICKET-3078] FileUploadException is masked behind WicketRuntimeException and not handled by a Form

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5-M2.1
• Fix Version/s: 1.5-M3
• Component/s: wicket, wicket-extensions
• Environment: Widnows, Jetty 7
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Ivan Vasilev
• Created: 23/Sep/10 21:13
• Updated: 25/Sep/10 18:24
• Resolved: 25/Sep/10 15:42

Description

I have a org.apache.wicket.markup.html.form.Form fileUploadForm, which has:
fileUploadForm.setMultiPart(true);
fileUploadForm.setMaxSize(Bytes.kilobytes(150));

When the form is submitted with a file larger than 150K the following methods are called:
fileUploadForm -> handleMultiPart -> ServletWebRequest.newMultipartWebRequest((Bytes maxsize) and inside it

try

{ return new MultipartRequest(getHttpServletRequest(), getFilterPrefix(), maxsize); }

catch (FileUploadException e)

{ throw new WicketRuntimeException(e); }

When the file size exceeds the maximum allowed a FileUploadException is thrown, however it is immediately caught and "masked" in a WicketRuntimeException. Inside the handleMultiPart method of the Form there is a catch block for FileUploadException, but the original exception is no longer of type FileUploadException and in this case the form fails to handle it. The result is that instead of an error message informing the user of exceeded limit a wicket stack trace page is displayed.

I'm not sure if this is part of wicket or wicket-extensions, because it involves classes from the both modules.