[WICKET-2964] Improve the code that uses copy-list-on-iterate pattern

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.9, 1.5-M1
• Fix Version/s: 1.4.11, 1.5-M2.1
• Component/s: wicket, wicket-auth-roles, wicket-datetime, wicket-examples, wicket-extensions, wicket-guice, wicket-jmx, wicket-quickstart, wicket-spring
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Martin Tzvetanov Grigorov
• Created: 25/Jul/10 13:32
• Updated: 17/Dec/13 19:17
• Resolved: 11/Aug/10 19:46

Description

http://www.zeroturnaround.com/blog/copy-on-iterate-java-idiom-considered-broken/ describes a problem in ArrayList constructor in JDK1.5 and less that they debugged in a Wicket application.

We can easy improve it by using the "simple solution":
for (Iterator i = Arrays.asList(collection.toArray()).iterator(); i.hasNext()