Wicket
  1. Wicket
  2. WICKET-291

return immutable parameter map or a copy of parameters

    Details

      Description

      WebRequestCodingStrategy#decode and PortletRequestCodingStrategy#decode try to remove values from the request's parameter map. As WicketPortletRequest returns just the immutable request parameters, this fails with an exception like this:

      java.lang.UnsupportedOperationException
      at java.util.Collections$1.remove(Collections.java:1012)
      at wicket.protocol.http.portlet.PortletRequestCodingStrategy.decode (PortletRequestCodingStrategy.java:119)
      at wicket.Request.getRequestParameters(Request.java:163)
      at wicket.RequestCycle.step(RequestCycle.java:992)
      at wicket.RequestCycle.steps(RequestCycle.java :1084)
      at wicket.RequestCycle.request(RequestCycle.java:454)
      at wicket.protocol.http.portlet.WicketPortlet.processAction(WicketPortlet.java:198)

      What we should do:
      1) make parameter map in both ServletWebRequest and WicketPortletRequest immutable
      2) remove the code that tries to remove wicket specific request parameters (why should we care about having them in there anyway)

        Issue Links

          Activity

            People

            • Assignee:
              Eelco Hillenius
              Reporter:
              Eelco Hillenius
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development