Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-2840

Remove final on AbstractRequestTargetUrlCodingStrategy#getMountPath()

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.7
    • 1.4.9
    • wicket
    • None

    Description

      Could final be removed of AbstractRequestTargetUrlCodingStrategy#getMountPath() ?

      I have a usecase where I need to mount a same page on several paths depending on the locale :

      • the login page is mounted on /login when the site is in english, and /connexion when the site is in french
      • The inverse should return 404 -> /login in french or /connexion in english
      • All links should link directly to the right page according to the site language

      The best way I found to implement this is to override AbstractRequestTargetUrlCodingStrategy#getMountPath() but because of the final qualifier, a lot of code has to be duplicated. Why is this method final and could it be removed ?

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ivaynberg Igor Vaynberg
            nricheton Nicolas Richeton
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment