Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-2840

Remove final on AbstractRequestTargetUrlCodingStrategy#getMountPath()

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.7
    • Fix Version/s: 1.4.9
    • Component/s: wicket
    • Labels:
      None

      Description

      Could final be removed of AbstractRequestTargetUrlCodingStrategy#getMountPath() ?

      I have a usecase where I need to mount a same page on several paths depending on the locale :

      • the login page is mounted on /login when the site is in english, and /connexion when the site is in french
      • The inverse should return 404 -> /login in french or /connexion in english
      • All links should link directly to the right page according to the site language

      The best way I found to implement this is to override AbstractRequestTargetUrlCodingStrategy#getMountPath() but because of the final qualifier, a lot of code has to be duplicated. Why is this method final and could it be removed ?

        Attachments

          Activity

            People

            • Assignee:
              ivaynberg Igor Vaynberg
              Reporter:
              nricheton Nicolas Richeton
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: