Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-2737

reduce number of SpringBeanLocator#getBeanNameOfClass calls.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.3
    • 1.4.7, 1.5-M1
    • wicket-spring
    • None

    Description

      In our application we use @SpringBean without name given extensively. It causes performance problems due to the fact that each time SpringBeanLocator uses its #getBeanNameOfClass method to look up a bean name within aplicationContext. Our inhouse improvement for this is to cache bean name for once localized bean in AnnotProxyFieldValueFactory. An instance of SpringBeanLocator gest always beanName in constructor. I attached the source code. It speeded up our app about 40%.
      The attached file provides improvement for 1.4.3 version.

      Attachments

        1. AnnotProxyFieldValueFactory.java
          6 kB
          Zbigniew Ruchała
        2. patch.txt
          12 kB
          Zbigniew Ruchała

        Activity

          People

            jdonnerstag Juegen Donnerstag
            zbigniewruchala Zbigniew Ruchała
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: