[WICKET-2678] isEnabled called in AjaxRequestTarget for Behaviors even if component is not Visible in hierarchy

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.5
• Fix Version/s: 1.4.6, 1.5-M1
• Component/s: wicket
• Assignee: Juegen Donnerstag
• Reporter: Martin Terra
• Created: 14/Jan/10 15:20
• Updated: 17/Jan/10 09:54
• Resolved: 17/Jan/10 09:54

Description

AjaxRequestTarget calls isEnabled for behaviors even if the related component is not visible in hierarchy.

Exlpicit problems: hide using ajax a panel containing datefield having datepicker behavior and the javascript will crash in browser. Mozilla will survive but ie8 will not execute ajaxpostcallhandlers.

Following code should probably call component.isVisibleInHierarchy instead of just isVisible:

public class AjaxRequestTarget implements IPageRequestTarget
{
...
if (component instanceof MarkupContainer)
{
((MarkupContainer)component).visitChildren(new Component.IVisitor<Component>()
{
public Object component(Component component)
{
if (component.isVisible())

{ component.renderHead(header); return CONTINUE_TRAVERSAL; }