[WICKET-2616] BaseWicketTester chooses a disabled component as the source of an AjaxFormSubmit event

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.4
• Fix Version/s: 1.4.6, 1.5-M1
• Component/s: wicket
• Environment: Linux, Sun JDK 1.6
• Assignee: Juegen Donnerstag
• Reporter: Jari Aarniala
• Created: 15/Dec/09 09:14
• Updated: 22/Dec/09 16:44
• Resolved: 22/Dec/09 16:44

Description

As of 1.4.4, disabled components can no longer submit forms (and rightly so):

http://fisheye6.atlassian.com/browse/wicket/trunk/wicket/src/main/java/org/apache/wicket/markup/html/form/Form.java?r1=835242&r2=829503

BaseWicketTester, however, doesn't check whether a submitting component is enabled when it chooses a component as the source of a submit event, it only checks the visibility:

http://fisheye6.atlassian.com/browse/wicket/trunk/wicket/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java?r=835641#l1287

We have a TextField with an AjaxFormSubmitBehavior, and in the same form there's a disabled AjaxButton. In our test, we trigger a submit event from the TextField, but BaseWicketTester sets the disabled AjaxButton as the source, causing the check in Form.java to fail and throw an Exception.

In the browser everything works fine, since the AjaxButton's inputName=value is not added to the request parameters, as expected.