[WICKET-2545] NullPointerException thrown from BaseWicketTester isComponent

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.4.1
• Fix Version/s: 1.4.4, 1.5-M1
• Component/s: wicket
• Environment: N/A
• Assignee: Igor Vaynberg
• Reporter: Ed Breuer
• Created: 27/Oct/09 15:00
• Updated: 27/Oct/09 22:18
• Resolved: 27/Oct/09 22:18

Description

If a component is not visible, then "getComponentFromLastRenderedPage" will return null (as opposed to failing if it is not present). In the check below, it seems like "Result.fail" is missing a "return" preceding it. Otherwise, the "component.getClass()" immediately following will generate an NullPointerException.

public <C extends Component> Result isComponent(String path, Class<C> expectedComponentClass)
{
Component component = getComponentFromLastRenderedPage(path);
if (component == null)

{ Result.fail("Component not found: " + path); // <-- Should return here. }

return isTrue("component '" + Classes.simpleName(component.getClass()) + "' is not type:" + // <-- NPE thrown here
Classes.simpleName(expectedComponentClass),
expectedComponentClass.isAssignableFrom(component.getClass()));
}