[WICKET-2488] QuickFix proposal WicketTesterHelper.assertEquals(final Collection<?> expects, final Collection<?> actuals) should compare list sizes

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4-RC7
• Fix Version/s: 1.4.2, 1.5-M1
• Component/s: wicket
• Assignee: Juegen Donnerstag
• Reporter: Martin Terra
• Created: 24/Sep/09 08:35
• Updated: 26/Sep/09 07:13
• Resolved: 26/Sep/09 07:13

Description

Simple bug:

WicketTesterHelper.assertEquals(expected, actual) method is supposed to check whether, for example, error messages match. However, if you have a situation with duplicate error messages, the test returns true even though logically the test should fail

Simple fix proposal:

Let's add size check in addition to the containsAll check:

public static void assertEquals(final Collection<?> expects, final Collection<?> actuals)
{
if (!expects.containsAll(actuals) || !actuals.containsAll(expects) || (actuals.size() != expects.size()))

{ failWithVerboseMessage(expects, actuals); }

}