[WICKET-2407] AbstractOptions of Palette may cause an HTML error with illegal chars

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.3.6
• Fix Version/s: 1.4.1
• Component/s: wicket-extensions
• Environment: Win XP, embedded Jetty / JBOss
• Assignee: Igor Vaynberg
• Reporter: Eyal Golan
• Created: 02/Aug/09 08:07
• Updated: 03/Aug/09 00:17
• Resolved: 03/Aug/09 00:17

Description

We encountered a small problem in our Palette.
Some of the values that were supposed to be in the choices (available and/or selected) had the '<' and '>' .
Because of that the options weren't rendererd correctly.
Looking at AbstractAction#onComponentTagBody I saw that it takes the value as it is and put it in the html:
String value = getConverter(displayClass).convertToString(displayValue, getLocale());
where displayValue is Object displayValue = renderer.getDisplayValue(choice);

Example fix:
In my code I overridden the getDisplayValue and getDisplayId of the renderer:
IChoiceRenderer choiceRenderer = new ChoiceRenderer("getFieldName", "getFieldName") {
private static final long serialVersionUID = 1L;

@Override
public Object getDisplayValue(Object object)

{ final String result = (String) super.getDisplayValue(object); return Strings.escapeMarkup(result, true, true).toString(); }

@Override
public String getIdValue(Object object, int index)

{ final String result = (String) super.getIdValue(object, index); return Strings.escapeMarkup(result, true, true).toString(); }

};