[WICKET-2366] Refactor: org.apache.wicket.util.string.Strings#fromEscapedUnicode(String escapedUnicodeString)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4-RC5, 1.4-RC6, 1.4-RC7, 1.4.0
• Fix Version/s: 1.4.0
• Environment: trunk
• Assignee: Johan Compagner
• Reporter: Martin Funk
• Created: 14/Jul/09 07:50
• Updated: 14/Jul/09 11:04
• Resolved: 14/Jul/09 11:04

Description

trying to understand the code I failed to see in which case the first two if statments hold true.
this smells so bad, I didn't check beyond.

public static String fromEscapedUnicode(String escapedUnicodeString)
{
int off = 0;
char[] in = escapedUnicodeString.toCharArray();
int len = in.length;
char[] convtBuf = new char[len];

if (convtBuf.length < len)
{
int newLen = len * 2;
if (newLen < 0)

{ newLen = Integer.MAX_VALUE; }

convtBuf = new char[newLen];
}
[...]