[WICKET-2344] Performance improvement: more efficient AnnotProxyFieldValueFactory cache

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.3, 1.5-M1
• Component/s: wicket-spring
• Assignee: Juegen Donnerstag
• Reporter: Arnout Engelen
• Created: 25/Jun/09 15:58
• Updated: 21/Dec/09 18:34
• Resolved: 03/Oct/09 13:24

Description

AnnotProxyFieldValueFactory holds a cache of proxies for singleton beans. The cache is checked like this:

// only check the cache if the bean is a singleton
if (locator.isSingletonBean() && cache.containsKey(locator))

{ return cache.get(locator); }

However, when the bean is referenced by type rather than by name (the default and common case), 'locator.isSingletonBean()' is a quite expensive operation, because it looks up the bean name by type (it indirectly calls BeanFactoryUtils.beanNamesForTypeIncludingAncestors()).

I think the call to locator.isSingletonBean() should either be omitted entirely (the cache only contains singleton proxies anyway), or omitted when annot.name() is blank.