Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-2018

Buttom subclasses getForm with a different sematic

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4-RC1
    • Fix Version/s: 1.4-RC2
    • Component/s: wicket
    • Labels:
      None

      Description

      Button.getForm() looks like
      public Form<?> getForm()
      {
      try

      { return super.getForm(); }

      catch (WicketRuntimeException wre)

      { // ignore this and return null. (Form.findSubmittingComponent expects this) }

      return null;
      }

      Obviously just because Form.findSubmittingComponent expects it. Instead of having different semantics per FormComponent.getForm, findSubmittingComponent should handle it. This is a good case for making a method final.

        Attachments

          Activity

            People

            • Assignee:
              jdonnerstag Juegen Donnerstag
              Reporter:
              jdonnerstag Juegen Donnerstag
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: