[WICKET-2018] Buttom subclasses getForm with a different sematic

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4-RC1
• Fix Version/s: 1.4-RC2
• Component/s: wicket
• Assignee: Juegen Donnerstag
• Reporter: Juegen Donnerstag
• Created: 11/Jan/09 10:25
• Updated: 11/Jan/09 10:52
• Resolved: 11/Jan/09 10:52

Description

Button.getForm() looks like
public Form<?> getForm()
{
try

{ return super.getForm(); }

catch (WicketRuntimeException wre)

{ // ignore this and return null. (Form.findSubmittingComponent expects this) }

return null;
}

Obviously just because Form.findSubmittingComponent expects it. Instead of having different semantics per FormComponent.getForm, findSubmittingComponent should handle it. This is a good case for making a method final.