[WICKET-1995] Method called unnecessarily in FormComponent

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4-RC1
• Fix Version/s: 1.4-RC2
• Component/s: wicket
• Environment: all
• Assignee: Igor Vaynberg
• Reporter: bernard
• Created: 26/Dec/08 21:33
• Updated: 01/Feb/09 03:30
• Resolved: 01/Feb/09 03:30

Description

In class FormComponent, in method validate(), isValid() is called too many times.

The last call can be removed by refactoring as follows:

Original 1.4 code:

public void validate()
{
validateRequired();
if (isValid())
{
convertInput();

if (isValid() && isRequired() && getConvertedInput() == null && isInputNullable())

{ reportRequiredError(); }

if (isValid())

{ validateValidators(); }

}
}

Refactored:

public void validate()
{
validateRequired();
if (isValid())
{
convertInput();

if(isValid())
{
// Check again because we think that convertInput() can set
// input to null after validateRequired() found valid input.
// When can convertInput() set input to null again?
if (isRequired() && getConvertedInput() == null && isInputNullable())

{ reportRequiredError(); }

else

{ validateValidators(); }

}
}
}